Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not mutate read-only files #1155

Merged
merged 3 commits into from
Sep 17, 2024
Merged

fix: do not mutate read-only files #1155

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b96215
fix: do not mutate read-only files
iloveitaly Aug 5, 2024
13cf59d
support is_writable on windows
coffee-cup Sep 17, 2024
9725f60
Merge branch 'main' into dont-mutate-read-only-files
coffee-cup Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 21 additions & 3 deletions src/nixpacks/files.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,21 @@ use anyhow::Result;
use ignore::WalkBuilder;
use std::{fs, io, path::Path};

#[cfg(unix)]
fn is_writable<P: AsRef<Path>>(path: P) -> io::Result<bool> {
use std::os::unix::fs::PermissionsExt;
let metadata = fs::metadata(path)?;
let permissions = metadata.permissions();
Ok(permissions.mode() & 0o200 != 0)
}

#[cfg(windows)]
fn is_writable<P: AsRef<Path>>(path: P) -> io::Result<bool> {
use std::os::windows::fs::MetadataExt;
let metadata = fs::metadata(path)?;
Ok(!metadata.file_attributes() & 1 != 0)
}

/// Copies a directory and all its contents to the destination path, recursively.
pub fn recursive_copy_dir<T: AsRef<Path>, Q: AsRef<Path>>(source: T, dest: Q) -> Result<()> {
let walker = WalkBuilder::new(&source)
Expand Down Expand Up @@ -30,9 +45,12 @@ pub fn recursive_copy_dir<T: AsRef<Path>, Q: AsRef<Path>>(source: T, dest: Q) ->
// copy files
else if file_type.is_file() {
fs::copy(from, &to)?;
// replace CRLF with LF
if let Ok(data) = fs::read_to_string(from) {
fs::write(&to, data.replace("\r\n", "\n"))?;

if is_writable(&to)? {
// replace CRLF with LF
if let Ok(data) = fs::read_to_string(from) {
fs::write(&to, data.replace("\r\n", "\n"))?;
}
}
}
}
Expand Down
Loading