Fix go runtime image #135
Fix go runtime image #135
Conversation
| @@ -0,0 +1,3 @@ | |||
| pub static DEFAULT_BASE_IMAGE: &str = "ghcr.io/railwayapp/nixpacks:debian-1652414952"; | |||
There was a problem hiding this comment.
I don't think we should be pinning it to a specific version.
There was a problem hiding this comment.
Why not? The base image is stored in the build plan and makes builds more reproducible. If it just uses the latest image then an update may break the build.
There was a problem hiding this comment.
Whenever a new version of the image goes out, we have to manually change the source code. I don't think this is a good idea (perhaps we can make it auto-update?)
There was a problem hiding this comment.
Yeah thats true, but it means we are being explicit about the image. Alternatively we could fetch the latest when nixpacks is run and then use that in the build plan. But that can come in a separate PR.
There was a problem hiding this comment.
Going to merge this for now since I prefer being explicit and pinning the dep over always pulling the latest. At least when it comes to the build plan generated.
There was a problem hiding this comment.
Yeah thats true, but it means we are being explicit about the image. Alternatively we could fetch the latest when nixpacks is run and then use that in the build plan. But that can come in a separate PR.
I'd be happy to implement this. Just a quick question, how can we make it so that it is still reproducible?
Run go code in debian slim, not the nixpacks debian image