-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install binutils in base docker image #339
Conversation
What is the base image size increase with this? The last I checked it was fairly large. I think we should prefer to install this only as needed (for specific packages or providers) as opposed to first installing it in the base image. Does this even fix the Rust issues? |
I'm not exactly sure how to check the increase. Though, installing only when needed is extremely hard. We can't just read build scripts and know when a binutils command is being invocated. And, issues with |
Build the base image locally before and after the change. I think it was like a 200MB increase.
That is fair. But this has never been an issue with Node, Python, or Ruby projects. So making all of those images 200MB larger isn't ideal. We could just install |
Before: 420MB I think that change is fine. |
I still think we should add it to the Rust provider first before adding it to the base image. I am not opposed to add it to the base in the future. But the default shouldn't be "add to base image". That is how we end up with a massive base that just has everything. Secondly, does this fix the Rust issues? |
I'll make this only apply to the rust provider now. And yes, this fixes the rust issues. |
Alright, CI is passing and now only binutils is installed in the Rust provider. |
What does this PR address?
ar
has been shown to not be installed in some cases and causes issues. This should fix it.Before submitting:
cargo test
?cargo fmt
,cargo check
andcargo clippy
locally to ensure that CI passes?