Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clippy fixes #352

Merged
merged 2 commits into from
Jul 22, 2022
Merged

Clippy fixes #352

merged 2 commits into from
Jul 22, 2022

Conversation

Milo123459
Copy link
Collaborator

@Milo123459 Milo123459 commented Jul 22, 2022 •
edited
Loading

What does this PR address?

Just some clippy fixes

Fixes # (issue)

Before submitting:

  • Make sure to follow GitHub's guide on creating PR.
  • Did you read through contribution guidelines?
  • Did your changes require updates to the documentation? Have you updated those accordingly?
  • Did you write tests to cover your changes? Did it pass locally when running cargo test?
  • Have you run cargo fmt, cargo check and cargo clippy locally to ensure that CI passes?

@Milo123459 Milo123459 merged commit a73875d into main Jul 22, 2022
@Milo123459 Milo123459 deleted the milo/clippy-fixes branch July 22, 2022 21:46
AhmedMozaly
AhmedMozaly reviewed Jul 22, 2022
View reviewed changes
tests/generate_plan_tests.rs
@@ -975,11 +971,7 @@ fn test_clojure_ring_app() -> Result<()> {
);
assert_eq!(
plan.build.unwrap().cmds,
Some(vec![format!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, this has been formatted with cargo fmt is there is multiple flavors for?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm? Wdym?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedMozaly AhmedMozaly AhmedMozaly left review comments

@JakeCooper JakeCooper JakeCooper approved these changes

@coffee-cup coffee-cup Awaiting requested review from coffee-cup

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Milo123459 @AhmedMozaly @JakeCooper