Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve parsing of node version #361

Merged
merged 1 commit into from
Jul 25, 2022
Merged

Improve parsing of node version #361

merged 1 commit into from
Jul 25, 2022

Conversation

Milo123459
Copy link
Collaborator

What does this PR address?

Fixes #356

Before submitting:

  • Make sure to follow GitHub's guide on creating PR.
  • Did you read through contribution guidelines?
  • Did your changes require updates to the documentation? Have you updated those accordingly?
  • Did you write tests to cover your changes? Did it pass locally when running cargo test?
  • Have you run cargo fmt, cargo check and cargo clippy locally to ensure that CI passes?

@Milo123459 Milo123459 merged commit 356d4a7 into main Jul 25, 2022
@Milo123459 Milo123459 deleted the milo/improve-node-parsing branch July 25, 2022 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coffee-cup coffee-cup coffee-cup approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using custom node version
2 participants
@Milo123459 @coffee-cup