-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
watch wallet trim input #681
Conversation
Here's the packed extension for this build: |
@@ -246,7 +246,7 @@ export const WatchWallet = ({ | |||
isLoading, | |||
isValid: inputIsValid, | |||
error, | |||
} = useValidateInput(input); | |||
} = useValidateInput(input.trim()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want to trim it? i'm thinking about typing rainbo w.eth
, isValid
will be true and they could watch it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trim only removes whitespace from the beginning and end of the string, so rainbo w.eth
keeps the space but
rainbo w.eth
becomes rainbo w.eth
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah duh, makes sense
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
trims the user input on watch wallet
Screen recordings / screenshots
What to test
Final checklist
yarn build
).