Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

watch wallet trim input #681

Merged
merged 5 commits into from
Jul 1, 2023
Merged

watch wallet trim input #681

merged 5 commits into from
Jul 1, 2023

Conversation

greg-schrammel
Copy link
Contributor

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

trims the user input on watch wallet

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-652e6cc1c732222ea460edeef7c5acaf2be7ee5c.zip

@greg-schrammel greg-schrammel changed the title watch wallet polish watch wallet trim input Jun 23, 2023
@@ -246,7 +246,7 @@ export const WatchWallet = ({
isLoading,
isValid: inputIsValid,
error,
} = useValidateInput(input);
} = useValidateInput(input.trim());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want to trim it? i'm thinking about typing rainbo w.eth, isValid will be true and they could watch it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trim only removes whitespace from the beginning and end of the string, so rainbo w.eth keeps the space but
rainbo w.eth becomes rainbo w.eth

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah duh, makes sense

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-a53a76ba9c0fadf837b6e484dcf8918ddeb67bd0.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-674cd2d43b9a70d464e069370f82489aecdc38a7.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-e03688e12f5982be19e263eb34d9808db98d2929.zip

@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Here's the packed extension for this build:
rainbowbx-79e1a4ac45cdb0b2ea1ac4652a3323a23cab6721.zip

@greg-schrammel greg-schrammel merged commit 22b669e into master Jul 1, 2023
@greg-schrammel greg-schrammel deleted the watch-wallet-polish branch July 1, 2023 21:46
greg-schrammel added a commit that referenced this pull request Jul 1, 2023
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

Here's the packed extension for this build:
rainbowbx-22b669e4601a5216dc4af37619a528c23eb4ba15.zip

BrodyHughes pushed a commit that referenced this pull request Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants