Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-865] Blur all input fields when the user clicks "Max" button in Swap flow #711

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

derHowie
Copy link
Member

What changed (plus any additional context for devs)

Removed focus after max

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@linear
Copy link

linear bot commented Jun 28, 2023

BX-865 Blur all input fields when the user clicks "Max" button in Swap flow

Currently when the user clicks the "Max" button in the Swap flow, the user is then unable to see the beginning of the number value in the Input Token Field — this is unideal

as a solution, we think that when the user clicks "Max" we should blur all the inputs in the swap flow, so that the inputs show the beginning of the numerical/decimal value instead of the end of it

Screenshot 2023-06-20 at 2.37.28 PM.png

shown in this screenshot is what the inputs look like when the user clicks "max" — you can see how the value in the top input doesnt give the user very useful context

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-863744eabbf756256c48a0fd7c7d8a782416a79f.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-147f4b427e4f424887efde67f09fee47a93f4b26.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-147f4b427e4f424887efde67f09fee47a93f4b26.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-438d59d9a853050e40c41b39a87427f1ebcfd1b3.zip

@derHowie derHowie merged commit a10ec34 into master Jun 30, 2023
@derHowie derHowie deleted the @chris/max-amount-blur branch June 30, 2023 21:54
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-a10ec3465c5db1955bb1abde94ee29db14657f26.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants