-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BX-806][BX-880] send to address fixes / improvements #712
Conversation
BX-880 Prevent 'My Wallets' Filtering After Successful Search on Send
I think we are incorrectly filtering the 'send to' input dropdown on send after a to-address has been selected. We should remove the filter so that the dropdown is still useful and provides information after a user has selected an address but decides to reopen the dropdown. |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
Here's the packed extension for this build: |
What changed (plus any additional context for devs)
The to address input mask is now clickable when dropdown is open, which will close the dropdown without losing your selection which I think satisfies the ask in BX-806.
I also noticed that we had some, what i think is unintentional, filtering happening in the dropdown once a toAddress was selected. The dropdown in this PR displays the entirety of the My Wallets and Watched Wallets section when a user opens the dropdown after having selected an address.
Screen recordings / screenshots
https://recordit.co/bJ9qpnFvt4
What to test
Would like people's opinion on the removal of filtering. I can't recall if this is a regression or not, but this seems like a better experience. Also curious if there is an unforeseen issue with allowing the dropdown close on input mask click. Please try to break it.
Final checklist
yarn build
).