Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-806][BX-880] send to address fixes / improvements #712

Merged
merged 4 commits into from
Jun 30, 2023

Conversation

derHowie
Copy link
Member

What changed (plus any additional context for devs)

The to address input mask is now clickable when dropdown is open, which will close the dropdown without losing your selection which I think satisfies the ask in BX-806.
I also noticed that we had some, what i think is unintentional, filtering happening in the dropdown once a toAddress was selected. The dropdown in this PR displays the entirety of the My Wallets and Watched Wallets section when a user opens the dropdown after having selected an address.

Screen recordings / screenshots

https://recordit.co/bJ9qpnFvt4

What to test

Would like people's opinion on the removal of filtering. I can't recall if this is a regression or not, but this seems like a better experience. Also curious if there is an unforeseen issue with allowing the dropdown close on input mask click. Please try to break it.

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@linear
Copy link

linear bot commented Jun 28, 2023

BX-880 Prevent 'My Wallets' Filtering After Successful Search on Send

I think we are incorrectly filtering the 'send to' input dropdown on send after a to-address has been selected. We should remove the filter so that the dropdown is still useful and provides information after a user has selected an address but decides to reopen the dropdown.

BX-806 There's no way to exit this screen without either cancelling the send or removing the address you are sending to.

image.png

cc mikearndt

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-0e4e9d23ce870b027e16ea8d5fcaf483763c308b.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-0ec1d176452195d031b58cdb016ab026bf98d004.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-42f6f53c38ed0d286b010d3ce726bc31fcaa4224.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-09698e15aa8743b71b119f2661d599d666b5bac6.zip

@derHowie derHowie merged commit 6939e31 into master Jun 30, 2023
@derHowie derHowie deleted the @chris/send-to-address-fixes branch June 30, 2023 19:56
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-6939e3123d3a10fd3906cc796ae0e2985111ba89.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants