fix keychain deserialize #735
Conversation
greg-schrammel
force-pushed
the
fix-remove-account
branch
from
24334cd to
81f2e67
Compare
| if (opts.accountsDeleted?.length) | ||
| privates.get(this).accountsDeleted = opts.accountsDeleted; |
There was a problem hiding this comment.
this is the bug fix, the rest I just replaced the ?. with a single check on top
|
Here's the packed extension for this build: |
| @@ -140,7 +140,9 @@ export class HdKeychain implements IKeychain { | |||
|
|
|||
| async removeAccount(address: Address): Promise<void> { | |||
| const accounts = await this.getAccounts(); | |||
| console.log('accounts', accounts); | |||
|
Here's the packed extension for this build: |
| @@ -8,17 +9,36 @@ import { KeychainType } from '~/core/types/keychainTypes'; | |||
| import { IKeychain, PrivateKey } from '../IKeychain'; | |||
| import { autoDiscoverAccounts } from '../utils'; | |||
|
|
|||
| type SupportedHDPath = "m/44'/60'/0'/0"; | |||
There was a problem hiding this comment.
We have this HD path hardcoded in like 3 different files now, we should probably move it to a common place.
(No need to do it right now)
| `${privates.get(this).hdPath}/${index}`, | ||
| ); | ||
| const _privates = privates.get(this)!; | ||
| if (!_privates.mnemonic) throw new Error('No mnemonic'); |
There was a problem hiding this comment.
only If it's called without calling init() first, I let the types guide me here, if ts said it can I it can, same for the others
pretty sure it should never happen in production, but these throws helped me find a bug I introduced elsewhere faster, so I think it's good for when we are changing code related
| const wallet = privates.get(this).getWalletForAddress(address); | ||
| const _privates = privates.get(this)!; | ||
| const wallet = _privates.getWalletForAddress(address); | ||
| if (!wallet?._isSigner) throw new Error('Not a signer'); |
| return wallet; | ||
| } | ||
|
|
||
| async serialize(): Promise<SerializedHdKeychain> { | ||
| const _privates = privates.get(this)!; | ||
| if (!_privates.mnemonic) throw new Error('No mnemonic'); |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test
Final checklist
yarn build).