raps failures fix #740
Merged
raps failures fix #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
greg-schrammel
approved these changes
Jul 10, 2023
estebanmino
reviewed
Jul 12, 2023
| // eslint-disable-next-line no-await-in-loop | ||
| await executeAction(actionParams); | ||
| const { hash } = await executeAction(actionParams); | ||
| hash && (await waitForNodeAck(hash, wallet.provider)); |
There was a problem hiding this comment.
i think we should only await if is not the last action, if is the last action we'd be delaying the execution of this method for no reason
|
Here's the packed extension for this build: |
|
Here's the packed extension for this build: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes BX-####
Figma link (if any):
What changed (plus any additional context for devs)
Before executing a new Rap action, make sure the node actually ack the last tx by calling
eth_getTransaction, that way we avoid have failures likefuture transaction tries to replace pendingScreen recordings / screenshots
What to test
Final checklist
yarn build).