Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arc: add background to dapp request #744

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

greg-schrammel
Copy link
Contributor

Fixes BX-####
Figma link (if any):

What changed (plus any additional context for devs)

the arc dapp request popup has a way bigger min width to the window itself
with this change the arc big popup will display as "fullscreen" with the cute background, and chrome/brave still the same

before/after arc

Screenshot 2023-07-10 at 11 25 39 Screenshot 2023-07-10 at 11 20 06

chrome (still the same)

Screenshot 2023-07-10 at 11 20 49

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-ab0de8b4d37ae9e413aaec7cbdca3132d0038833.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-f39030e259459dd5164f2ef673e9f71a10eb3f9c.zip

@greg-schrammel greg-schrammel merged commit 926b560 into master Jul 13, 2023
@greg-schrammel greg-schrammel deleted the weird-popup-windows branch July 13, 2023 20:41
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-926b5605a3ae72cf6f4e1e609db32ddbe0cacb04.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants