Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hide balances in swap #760

Merged
merged 3 commits into from
Jul 13, 2023
Merged

Conversation

estebanmino
Copy link
Contributor

@estebanmino estebanmino commented Jul 12, 2023

Fixes BX-####
Figma link (if any):

trying command K pr i found we're not hiding balances on swap when settings hide balances is off

this pr adds Asterisks to copy the behavior from send flow

What changed (plus any additional context for devs)

https://www.loom.com/share/f75dfcc3653d4b25a1804dac98f9d759

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-72d4634ea73f284a8f18d125909ee3dd86bab55d.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-2cda8733df05569f5e08e95d7cb67c63f097dd76.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-2cda8733df05569f5e08e95d7cb67c63f097dd76.zip

@estebanmino estebanmino merged commit 1800a1b into master Jul 13, 2023
@estebanmino estebanmino deleted the @esteban/hide-balances-in-swap branch July 13, 2023 10:12
@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-1800a1b458d3f28584ade7e6decd3ff55566e671.zip

greg-schrammel pushed a commit that referenced this pull request Jul 13, 2023
BrodyHughes pushed a commit that referenced this pull request Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants