Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BX-795] Assumed I could press "ENTER" key to submit my Send #763

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

derHowie
Copy link
Member

What changed (plus any additional context for devs)

Focusing the send cta when the send review sheet is done animating. I also noticed that transparent colored buttons did not appear selected when focused. They will now take on the accent color as border color when selected.

Screen recordings / screenshots

https://recordit.co/17ZRI2jVcZ

What to test

Ensure that the send cta is focused after the send review sheet appears

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-e2c58afe883a3b37e4497b1d80e1100c59e286a5.zip

Copy link
Contributor

@greg-schrammel greg-schrammel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-ab4d71098c2e97c365ddfb91786152fd62229aea.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-ab4d71098c2e97c365ddfb91786152fd62229aea.zip

@derHowie derHowie merged commit 67837ec into master Jul 14, 2023
@derHowie derHowie deleted the @chris/autofocus-send-cta branch July 14, 2023 19:04
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-67837ece54063743a0d4bb67d55645557a2c40c9.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants