Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix send crash #766

Merged
merged 6 commits into from
Jul 21, 2023
Merged

fix send crash #766

merged 6 commits into from
Jul 21, 2023

Conversation

brunobar79
Copy link
Member

Fixes https://rainbow-me.sentry.io/issues/4308530426/?project=4504012577112064&query=is%3Aunresolved&referrer=issue-stream&stream_index=0
Figma link (if any):

What changed (plus any additional context for devs)

missing an optional

Screen recordings / screenshots

What to test

Final checklist

  • I have tested my changes in a LavaMoat bundle (yarn build).
  • I have tested my changes in Chrome & Brave.
  • If your changes are visual, did you check both the light and dark themes?

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-90274aece797effe45b2e81da22effc876db3483.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-f15ccbcbece201fca2d546e86d59624238da5cc3.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-2c6acf565e5190d08931029c3eb15b32f3419617.zip

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-027ad2ea2d22f6caed12e8be8b5f11d6619dc16d.zip

greg-schrammel
greg-schrammel reviewed Jul 20, 2023
View reviewed changes
src/entries/popup/pages/send/index.tsx
@@ -311,7 +311,7 @@ export function Send() {
if (
!prevToAddressIsSmartContract &&
toAddressIsSmartContract &&
!toEnsName.includes('argent.xyz')
!toEnsName?.includes('argent.xyz')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be failing in the typecheck

@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-d3a82bde9debe1b7297b546ae7524a62b20371ed.zip

@github-actions
Copy link

Here's the packed extension for this build:
rainbowbx-92d86caac72f6486614e6b4e3ee1b8591234f611.zip

@brunobar79 brunobar79 merged commit dab438a into master Jul 21, 2023
@brunobar79 brunobar79 deleted the @bruno/send-crash branch July 21, 2023 01:06
@github-actions
Copy link

Here's the packed extension for this build:
node_modules.tar.gz
rainbowbx-dab438a66fe76bacd902979b09f3824efeecdd89.zip

@DanielSinclair DanielSinclair mentioned this pull request Jul 22, 2023
Merged
derHowie pushed a commit that referenced this pull request Jul 22, 2023
@brunobar79 @derHowie
fix send crash (#766)
78e1103
derHowie pushed a commit that referenced this pull request Jul 24, 2023
@brunobar79 @derHowie
fix send crash (#766)
85d5417
BrodyHughes pushed a commit that referenced this pull request Jul 24, 2023
@brunobar79 @BrodyHughes
fix send crash (#766)
2d8d1bd
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derHowie derHowie derHowie approved these changes

@greg-schrammel greg-schrammel greg-schrammel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brunobar79 @greg-schrammel @derHowie