prevent quotes from the wrong type being passed to the wrong fn (#6436)

rainbow-me · Jan 31, 2025 · c17fbf3 · c17fbf3
1 parent d3485bb
commit c17fbf3
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/raps/actions/crosschainSwap.ts b/src/raps/actions/crosschainSwap.ts
@@ -1,5 +1,5 @@
 import { Signer } from '@ethersproject/abstract-signer';
-import { CrosschainQuote, fillCrosschainQuote } from '@rainbow-me/swaps';
+import { CrosschainQuote, fillCrosschainQuote, SwapType } from '@rainbow-me/swaps';
 import { Address } from 'viem';
 import { estimateGasWithPadding, getProvider, toHex } from '@/handlers/web3';
 import { add } from '@/helpers/utilities';
@@ -155,7 +155,7 @@ export const executeCrosschainSwap = async ({
   wallet: Signer;
   referrer?: ReferrerType;
 }) => {
-  if (!wallet || !quote) return null;
+  if (!wallet || !quote || quote.swapType !== SwapType.crossChain) return null;
 
   const transactionParams = {
     gasLimit: toHex(gasLimit) || undefined,

diff --git a/src/raps/actions/swap.ts b/src/raps/actions/swap.ts
@@ -290,9 +290,10 @@ export const executeSwap = async ({
   } else if (quote.swapType === SwapType.unwrap) {
     return unwrapNativeAsset(quote.sellAmount, wallet, getWrappedAssetAddress(quote), transactionParams);
     // Swap
-  } else {
+  } else if (quote.swapType === SwapType.normal) {
     return fillQuote(quote, transactionParams, wallet, permit, chainId as number, REFERRER);
   }
+  return null;
 };
 
 export const swap = async ({