Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Points Breakdown Panel Not Prompting #6166

Merged
merged 1 commit into from
Oct 5, 2024
+7 −7
Merged

Fix Points Breakdown Panel Not Prompting #6166

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/screens/points/content/PointsContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,16 +747,16 @@ export function PointsContent() {
</Inset>
{!shouldDisplayError ? (
<Inset horizontal="20px" top="24px">
<Stack space="28px">
<Stack space="20px">
<Box gap={28}>
<Box gap={20}>
<Text color="label" size="20pt" style={{ marginLeft: 4 }} weight="heavy">
{i18n.t(i18n.l.points.points.my_points)}
</Text>
<Box flexDirection="row" alignItems="center" paddingLeft="4px">
{canDisplayTotalPoints ? <RainbowText totalPointsString={totalPointsString} /> : <Skeleton height={31} width={200} />}
</Box>
</Stack>
<Box gap={24}>
</Box>
<Box width="full" gap={24}>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

giving this box width="full" fixed the issue. Converted all the stacks to Boxes because Stack's cannot take width prop

{!!cardIds.length && !isReadOnlyWallet && <RemoteCardCarousel key="remote-cards" />}
<InfoCards points={points} />
</Box>
Expand Down Expand Up @@ -877,7 +877,7 @@ export function PointsContent() {
<Separator color={isDarkMode ? 'separatorSecondary' : 'separatorTertiary'} thickness={1} />
</>
)}
<Stack space="20px">
<Box gap={20}>
<Inset left="4px">
<Text color="label" size="20pt" weight="heavy">
{i18n.t(i18n.l.points.points.leaderboard)}
Expand Down Expand Up @@ -944,8 +944,8 @@ export function PointsContent() {
) : (
<Skeleton height={400} width={deviceWidth - 40} />
)}
</Stack>
</Stack>
</Box>
</Box>
</Inset>
) : (
<Box alignItems="center" justifyContent="center" height="full" width="full">
Expand Down
Loading