Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Claimables analytics #6195

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Claimables analytics #6195

merged 1 commit into from
Oct 15, 2024

Conversation

benisgold
Copy link
Member

Fixes APP-1929

What changed (plus any additional context for devs)

forgot to add claimables analytics

Screen recordings / screenshots

What to test

@benisgold benisgold requested a review from walmat October 11, 2024 18:47
@linear Linear
Copy link

linear bot commented Oct 11, 2024

APP-1929 Claimables Analytics

@brunobar79
Copy link
Member

Launch in simulator or device for a17ddc8

@benisgold benisgold added release for release blockers and release candidate branches and removed nice for release labels Oct 15, 2024
brunobar79
brunobar79 approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@brunobar79 brunobar79 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brunobar79 brunobar79 merged commit 7d75535 into develop Oct 15, 2024
8 checks passed
@brunobar79 brunobar79 deleted the @benisgold/claim-analytics branch October 15, 2024 16:28
@sentry-io Sentry.io
Copy link

sentry-io bot commented Oct 18, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: [ClaimingTransactionClaimable]: Failed to estimate gas limit sentryTransport(src/logger/index) View Issue
  • ‼️ Error: [ClaimingTransactionClaimable]: Failed to claim claimable due to rap error <global>(src/logger/index) View Issue
  • ‼️ Error: [ClaimSponsoredClaimable]: Sponsored claim api call returned unsuccessful response <global>(src/logger/index) View Issue
  • ‼️ Error: [ClaimSponsoredClaimable]: Failed to execute sponsored claim api call <global>(src/logger/index) View Issue
  • ‼️ Error: [ClaimSponsoredClaimable]: Failed to claim claimable due to unhandled error <global>(src/logger/index) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@walmat walmat walmat approved these changes

@brunobar79 brunobar79 brunobar79 approved these changes

@greg-schrammel greg-schrammel Awaiting requested review from greg-schrammel

Assignees
No one assigned
Labels
release for release blockers and release candidate branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@benisgold @brunobar79 @walmat