swap: make ChainSelector row fixed to top of list #6206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greg-schrammel
requested review from
walmat,
christianbaroni,
benisgold and
BrodyHughes
walmat
requested changes
Oct 16, 2024
walmat
approved these changes
Oct 16, 2024
walmat
approved these changes
Oct 16, 2024
benisgold
approved these changes
Oct 23, 2024
greg-schrammel
deleted the
gregs/app-1514-make-chainselector-row-fixed-to-top-of-list
branch
greg-schrammel
added a commit
that referenced
this pull request
Oct 24, 2024
* ChainSelector row fixed to top of list * sticky chainselector on token to sell too
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
should we add some animation/separator/fade/idk to the list clipping behind this header?
Screen recordings / screenshots
Screen.Recording.2024-10-16.at.03.19.20.mov
What to test