Fix userAssets query enabled config #6243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinchung
changed the title
jinchung
force-pushed
the
@jin/user-assets-retry
branch
from
4c55bd1 to
785117c
Compare
jinchung
commented
Oct 30, 2024
jinchung
commented
Oct 30, 2024
jinchung
commented
Oct 30, 2024
| try { | ||
| const url = `/${chainId}/${address}/assets/?currency=${currency.toLowerCase()}`; |
There was a problem hiding this comment.
this was where we were seeing the "No auth" error message on the retries - have it following the same pattern we have elsewhere now
jinchung
changed the title
jinchung
commented
Oct 31, 2024
jinchung
commented
Oct 31, 2024
jinchung
commented
Oct 31, 2024
jinchung
commented
Oct 31, 2024
jinchung
commented
Oct 31, 2024
jinchung
commented
Oct 31, 2024
jinchung
force-pushed
the
@jin/user-assets-retry
branch
from
600978a to
f3f7994
Compare
walmat
reviewed
Oct 31, 2024
jinchung
commented
Oct 31, 2024
jinchung
commented
Oct 31, 2024
…ues on the results
…p and fails when trying to index get function
…n userAssets store
…open but missing user assets data
jinchung
force-pushed
the
@jin/user-assets-retry
branch
from
1415171 to
0e8830c
Compare
walmat
approved these changes
Oct 31, 2024
benisgold
approved these changes
Nov 1, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-1977
What changed (plus any additional context for devs)
There is a race condition that can happen when we first start the app and do a user assets query function call without the address. We weren't disabling the query function call, resulting in us to just return an empty state and therefore empty objects. There could be a race condition from when we set the incorrect data but before we get the latest data with the account address, when a user could open the swap state, preventing further updates from the user assets store from getting synced.
There were a few different issues happening at the same time, but the retry errors we were getting were not causing this - they were other issues.
This will also be improved once we have Ben's user assets consolidation work in place - we should just make sure to keep some of the changes we introduced here, some of which is more aligned with the original user assets query logic.
Screen recordings / screenshots
RPReplay_Final1730337157.MP4
What to test
Try to open swaps right after starting the app - the input asset may not be selected by default automatically if it hasn't loaded in time, but the input asset list should refresh with updated assets when they arrive.