Skip node ack check if txn params are for mainnet #6261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jinchung
commented
Nov 11, 2024
•
jinchung
commented
- Simplifies node ack check to being before any rap action past the first one needs it (means we no longer need to check if there is more than 1 action after the first action; it also means we don't unnecessarily do this check after the last action)
- Simplifies the node ack check to only be for non-mainnet transactions
- Caps the number of retries for node ack to 10
jinchung
merged commit 65f96ac
into
@bruno/remove-permit-on-mainnet
5 of 6 checks passed
jinchung
added a commit
that referenced
this pull request
Nov 12, 2024
* remove permit usage on mainnet swaps * remove logging * make approval + swap parallel again * remove import * Skip node ack check if txn params are for mainnet (#6261) * Skip node ack check if txn params are for mainnet * Cap retries to 10 retries for node ack * Remove ALLOWS_PERMIT gas estimation checks --------- Co-authored-by: Jin <jin.chung17@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.