fix lp badge gradient overflow and android shadows #6296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
approved these changes
Dec 4, 2024
| @@ -137,6 +137,7 @@ export const LpPositionListItem: React.FC<Props> = ({ assets, totalAssetsValue, | |||
| </Box> | |||
| <LpRangeBadge | |||
| assets={assets.map((underlying, index) => ({ | |||
| id: underlying.asset.asset_code, | |||
There was a problem hiding this comment.
possible for two LPs to have the same asset? If so this would create double indices
There was a problem hiding this comment.
These are for each LP pool, and to my knowledge there are no LP pools that allow you to pool two of the same asset, I don't think that would make sense.
| @@ -54,7 +55,7 @@ export const LpRangeBadge = ({ assets }: LpRangeBadgeProps) => { | |||
|
|
|||
| return ( | |||
| <Box | |||
| key={`${asset.color}-${asset.allocationPercentage}`} | |||
| key={asset.id} | |||
derHowie
approved these changes
Dec 4, 2024
brunobar79
added
release
ibrahimtaveras00
pushed a commit
that referenced
this pull request
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-####
What changed (plus any additional context for devs)
Small UI bug fixes