Browser upgrades follow-up #6300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e browser tab, remove unnecessary 'worklet' directive
christianbaroni
added
the
release
brunobar79
reviewed
Dec 5, 2024
brunobar79
approved these changes
Dec 5, 2024
This avoids repeated serialization of worklets, which based on thorough testing of the app, can be safely cached — it noticeably smooths out gesture-driven interactions and should speed up anything that involves frequently/repeatedly called worklets
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: npm/react-native-reanimated@3.16.2 |
If you tapped around the edge of the tab button, you'd see a different context menu pop up than if you long pressed — this removes the duplicate menu
derHowie
approved these changes
Dec 5, 2024
ibrahimtaveras00
pushed a commit
that referenced
this pull request
Dec 6, 2024
* Enable/disable WebView JS handlers when navigating to or away from the browser tab, remove unnecessary 'worklet' directive * Patch Reanimated to cache all worklets This avoids repeated serialization of worklets, which based on thorough testing of the app, can be safely cached — it noticeably smooths out gesture-driven interactions and should speed up anything that involves frequently/repeatedly called worklets * [Android] Fix duplicate tab button context menu If you tapped around the edge of the tab button, you'd see a different context menu pop up than if you long pressed — this removes the duplicate menu * Fix Podfile.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
Screen recordings / screenshots
What to test