Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E2E split into parallel and serial flows #6317

Merged
merged 8 commits into from
Dec 11, 2024
Merged

Conversation

brunobar79
Copy link
Member

@brunobar79 brunobar79 commented Dec 10, 2024

What changed (plus any additional context for devs)

Splits all e2e into two groups that run separately:

  • Parallel
  • Serial (require hardhat)

This should fix all the concurrency issues we had (nonce missmatch / balance missmatch / noNetwork)

Screen recordings / screenshots

None

What to test

Ci should be green

@brunobar79
Copy link
Member Author

Launch in simulator or device for 5a1ee8b

@brunobar79 brunobar79 changed the title [WIP] e2e split into parallel and serial flows E2E.split into parallel and serial flows Dec 11, 2024
@brunobar79 brunobar79 changed the title E2E.split into parallel and serial flows E2E split into parallel and serial flows Dec 11, 2024
Copy link
Contributor

@walmat walmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you for tackling this

Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌱

@derHowie derHowie merged commit c6da61f into develop Dec 11, 2024
8 checks passed
@derHowie derHowie deleted the @bruno/split-tests branch December 11, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants