Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve FID for wallet addresses #6330

Merged
merged 4 commits into from
Dec 16, 2024
Merged

Retrieve FID for wallet addresses #6330

merged 4 commits into from
Dec 16, 2024

Conversation

walmat
Copy link
Contributor

@walmat walmat commented Dec 12, 2024

What changed (plus any additional context for devs)

This hook retrieves the farcaster id for the first found non-watched wallet for personalization

Screen recordings / screenshots

is not watched wallet

Screenshot 2024-12-12 at 3 35 50 PM Screenshot 2024-12-12 at 3 35 39 PM

is watched wallet (should be null)

Screenshot 2024-12-12 at 3 34 48 PM Screenshot 2024-12-12 at 3 34 36 PM

What to test

will write some unit tests for this momentarily

@walmat walmat requested a review from derHowie December 13, 2024 19:20
Copy link
Member

@derHowie derHowie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. That console.log in the new hook is firing a bunch. Can we take that out before merging?

@brunobar79
Copy link
Member

Launch in simulator or device for 0e9c027

@walmat walmat merged commit 2ad4393 into develop Dec 16, 2024
8 checks passed
@walmat walmat deleted the @matthew/use-fid branch December 16, 2024 16:44
brunobar79 added a commit that referenced this pull request Dec 19, 2024
* portal

* trending tokens

* network switcher

* feat flag

* opss

* i18n

* performance

* ops

* Wire up trending tokens UI (#6292)

* implement gql query to get trending tokens for selected network and display them

* fix dragging issue with no chainId and tapping empty space resetting network to all networks

* add mock handler for navigating to swaps flow

* fix lint

* shuffle files and break out network switcher to be composable

* refactor SwapCoinIcon to use a size prop instead of small, large, xlarge, etc.

* add view token analytics event

* add time tracking to discover screen

* add tracking for if user has swapped a trending token

* decouple network selector from trending tokens and add rest of analytics events

* fix customize network banner not being dismissable

* revert white color token change

* lint?

* add remote config flag for trending tokens

* scroll & light mode

* better categories colors

* fix select all chain badges

* polish ui

* better buttons

* save

* align friends pfps

* fix price change timeframes

* fix images

* better currency formatting

* fix comment

* fix network button selecting the wrong one

* fix: tt sort (#6337)

* TT fixes (#6338)

* remove arrows for price change

* fix friend holders display

* fix dupes

* align and make friends looks better

* remove spread

* ops

---------

Co-authored-by: gregs <ukfaeku@gmail.com>

* fix: tt -> swaps nav (#6343)

* fix missing header height on the sheet (#6315)

* convert network accessors to functions (#6219)

* convert network accessors to functions

* backend networks store

* wrote a couple worklet functions to get swaps working

* fix other calls

* Update package.json

* Update ios/Podfile.lock

* move all functions into backendNetworksStore and replace calls

* refresh podlock

* no clue what happened during merge

* fix: APP-2021

* fix: APP-2022

* fix build and lint

* Bump nanoid from 3.3.7 to 3.3.8 in /src/design-system/docs (#6320)

Bumps [nanoid](https://github.com/ai/nanoid) from 3.3.7 to 3.3.8.
- [Release notes](https://github.com/ai/nanoid/releases)
- [Changelog](https://github.com/ai/nanoid/blob/main/CHANGELOG.md)
- [Commits](ai/nanoid@3.3.7...3.3.8)

---
updated-dependencies:
- dependency-name: nanoid
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update default currentNonce value to -1 (use case: fresh wallet or freshly imported wallet) (#6324)

* Set currentNonce default to -1 if not stored (use case: fresh wallet or freshly imported wallet)

* Update pending txn logic to treat default of -1 for currentNonce when it does not exist yet

* Replace node ack retries with a small delay (#6326)

* fix undefined size on TextShadow component when switching themes (#6329)

* chore: update swaps sdk + use new getWrappedAssetAddress method (#6327)

* NFT checker 2.0 (#6293)

* Add inkchain support (#6323)

* add basic entries

* update chain badge assets

* alphabetizing imports / mappings

* update tokenSearch, default bips

* alphabetize and clean up

* alphabetize en_US

* add explainer text and colors

* update simplehash networks

* update chainIds and explainer copy

* chain IDs

* add proper colors

* add badges I have access to

* add assets to assets folder as well

* add assets

* comment out other chains

* remove badges for other networks

* fix ethereum badge assets

* idk if podlock is needed

* Readd avalanche network type

* Add new chains to chainsIdByNetwork mapping

---------

Co-authored-by: Bruno Barbieri <brunobar79@gmail.com>
Co-authored-by: jinchung <jin.chung17@gmail.com>

* Retrieve FID for wallet addresses (#6330)

* bump iOS and Android to v1.9.50 (#6340)

* Icons hotfix (#6342)

* handle raw response from contract call correctly

* fix logic to reveal icons

* resolve missing imports

* chainId

* prioritize symbol & not resize selected catergory pill

* discorty screen trending tokens separator

* add remote config to control limit

* remove unused import

* chore: temp hc for review at limit 12

* Update iOS and Android to v1.9.51 (#6346)

* chore: remove unnecessary hc limit

* fix: nav to swap from tt row (#6347)

* Fix non fractal price data formatter (#6348)

* format price for amounts >1 different than fractal amounts

* handle >6 figs native value different and show in compact notation to prevent row collision

* prevent token symbol from growing beyond what it needs

* Update src/components/Discover/TrendingTokens.tsx

* remove DebugLayout

* Fix spacing to 28px in latest TestFlight version (#6351)

* fix spacing between items

* Update src/components/Discover/TrendingTokens.tsx

* fix network switcher using name instead of label (#6350)

* add default initial pinned chains (#6349)

* portal

* trending tokens

* network switcher

* feat flag

* opss

* i18n

* performance

* ops

* Wire up trending tokens UI (#6292)

* implement gql query to get trending tokens for selected network and display them

* fix dragging issue with no chainId and tapping empty space resetting network to all networks

* add mock handler for navigating to swaps flow

* fix lint

* shuffle files and break out network switcher to be composable

* refactor SwapCoinIcon to use a size prop instead of small, large, xlarge, etc.

* add view token analytics event

* add time tracking to discover screen

* add tracking for if user has swapped a trending token

* decouple network selector from trending tokens and add rest of analytics events

* fix customize network banner not being dismissable

* revert white color token change

* lint?

* add remote config flag for trending tokens

* scroll & light mode

* better categories colors

* fix select all chain badges

* polish ui

* better buttons

* save

* align friends pfps

* fix price change timeframes

* fix images

* better currency formatting

* fix comment

* fix network button selecting the wrong one

* fix: tt sort (#6337)

* TT fixes (#6338)

* remove arrows for price change

* fix friend holders display

* fix dupes

* align and make friends looks better

* remove spread

* ops

---------

Co-authored-by: gregs <ukfaeku@gmail.com>

* fix: tt -> swaps nav (#6343)

* convert network accessors to functions (#6219)

* convert network accessors to functions

* backend networks store

* wrote a couple worklet functions to get swaps working

* fix other calls

* Update package.json

* Update ios/Podfile.lock

* move all functions into backendNetworksStore and replace calls

* refresh podlock

* no clue what happened during merge

* fix: APP-2021

* fix: APP-2022

* fix build and lint

* NFT checker 2.0 (#6293)

* Icons hotfix (#6342)

* handle raw response from contract call correctly

* fix logic to reveal icons

* resolve missing imports

* chainId

* prioritize symbol & not resize selected catergory pill

* discorty screen trending tokens separator

* add remote config to control limit

* remove unused import

* chore: temp hc for review at limit 12

* chore: remove unnecessary hc limit

* Fix non fractal price data formatter (#6348)

* format price for amounts >1 different than fractal amounts

* handle >6 figs native value different and show in compact notation to prevent row collision

* prevent token symbol from growing beyond what it needs

* Update src/components/Discover/TrendingTokens.tsx

* remove DebugLayout

* Fix spacing to 28px in latest TestFlight version (#6351)

* fix spacing between items

* Update src/components/Discover/TrendingTokens.tsx

* fix network switcher using name instead of label (#6350)

* add default initial pinned chains (#6349)

* fix network switcher to use a network chip when odd number of pinned (#6354)

* Use sheet instead of custom AbsolutePortal (#6357)

* use sheet instead of absoluteportal

* fix timings

* add a little delay between transition expanded and collapsed

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Matthew Wall <matthew.wallt@gmail.com>
Co-authored-by: Christopher Howard <derhowiedesigns@gmail.com>
Co-authored-by: Bruno Barbieri <1247834+brunobar79@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Jin <jin.chung17@gmail.com>
Co-authored-by: Wayne Cheng <677680+welps@users.noreply.github.com>
Co-authored-by: Bruno Barbieri <brunobar79@gmail.com>
Co-authored-by: Ibrahim Taveras <ibrahim@rainbow.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants