Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icons hotfix pt 2 #6345

Merged
merged 2 commits into from
Dec 17, 2024
Merged

icons hotfix pt 2 #6345

merged 2 commits into from
Dec 17, 2024

Conversation

brunobar79
Copy link
Member

Fixes APP-####

What changed (plus any additional context for devs)

  • Added missing migration
  • Temporarily disable old icons sheet

Screen recordings / screenshots

Screenshot 2024-12-17 at 4 55 17 PM

What to test

Go from prod to this branch and you should only see the icons you have

@brunobar79 brunobar79 requested a review from jinchung December 17, 2024 21:55
Copy link
Member

@jinchung jinchung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌮

@jinchung jinchung merged commit 2163417 into develop Dec 17, 2024
5 checks passed
@jinchung jinchung deleted the @bruno/icons-hotfix-pt-2 branch December 17, 2024 21:56
ibrahimtaveras00 pushed a commit that referenced this pull request Dec 17, 2024
* added migration to reset icon handled flag

* ignore old icon sheets temporarilly
@brunobar79
Copy link
Member Author

Launch in simulator or device for b15c657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants