Initial charts cleanup #6387
Merged
Initial charts cleanup #6387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
approved these changes
Jan 9, 2025
derHowie
approved these changes
Jan 9, 2025
| (!hasBalance && 68) + | ||
| additionalContentHeight + | ||
| (additionalContentHeight === 0 ? 0 : scrollableContentHeight), | ||
| carouselHeight + heightWithChart - (!hasBalance && 68) + additionalContentHeight + (additionalContentHeight === 0 ? 0 : true), |
There was a problem hiding this comment.
I know this isn't yours originally but I'm having a hard time understanding this code. Specifically the purpose of the final conditional: (additionalContentHeight === 0 ? 0 : true).
True here is a 1. What is the significance of adding 1 when additionalContentHeight is 0?
Comment on lines
+47
to
+52
| if (!value) { | ||
| return defaultPriceValue || ''; | ||
| } | ||
| if (value === 'undefined') { | ||
| return nativeSelected?.alignment === 'left' ? `${nativeSelected?.symbol}0.00` : `0.00 ${nativeSelected?.symbol}`; | ||
| } |
There was a problem hiding this comment.
Not really an issue, but curious why we handle these two cases differently. Is it so that we don't ever flash $0.00 on tokens with actual value?
christianbaroni
added
merge when ready
performance
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed (plus any additional context for devs)
AnimatedTextwhich cuts down on jank when interacting with the chartScreen recordings / screenshots
What to test