Make transaction request parameters less rigid #6390
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2248
What changed (plus any additional context for devs)
1. Transaction Message Card Component Update
Type Definition Changes
RPCMethod
from walletConnect typesmethod
prop type fromRPCMethod
tostring
for better flexibility2. New Build Transaction Helper
New File Creation
src/helpers/buildTransaction.ts
getGasLimitForSuggestedGas
buildTransaction
Gas Estimation Logic
SignTransactionSheet
to dedicated helperTransaction Building
3. Sign Transaction Sheet Refactor
Code Cleanup
Integration Changes
buildTransaction
helperThis PR represents a significant improvement in the transaction handling architecture, moving complex transaction building logic into a dedicated helper while simplifying the transaction message card component. The changes promote better code organization and maintainability.
Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-09.at.11.52.55.mp4
What to test
sends, sign, txns from MWP, Dapp Browser, WC