-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistencies between swaps store slippage and shared value #6399
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding the ability to set the slippage in the route params is good but none of the current routes to swaps were trying to do that, and the fallback logic is the same as before so I'm not understanding how this fixes the linked issue.
That wasn't the issue. The issue was with the shared value and swaps store value being out of sync with one another, which is fixed in this PR. That deeplink / route param fix is just another one I noticed during investigating. |
Fixes APP-2255
What changed (plus any additional context for devs)
1. Swap Navigation Parameters Enhancement
State Management
getSwapsNavigationParams
Parameter Processing
Code Organization
2. Swap Provider Updates
State Management
Code Cleanup
This PR improves the swap navigation parameter handling by adding proper slippage management and better state organization while maintaining existing functionality.
Screen recordings / screenshots
Simulator.Screen.Recording.-.iPhone.16.Pro.-.2025-01-14.at.12.24.57.mp4
What to test
test swaps on different chains and see the
minimum value received
changes with the slippage change