-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanded state phase 1 cleanup #6422
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
walmat
reviewed
Jan 28, 2025
walmat
approved these changes
Jan 28, 2025
christianbaroni
approved these changes
Jan 29, 2025
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes APP-2293, APP-2291
What changed (plus any additional context for devs)
toFixedWorklet
safe math util to handle negative number rounding correctly & negative number leading 0s. Previously a number like "-0.121" was returned incorrectly as "-.11". In some cases it could return invalid number formats such as "0.-3". This fixes an issue where the percentage change label would fail to display despite the data being available.toFixedWorklet
testuseRatio
hook.Additional changes merged from Christian's cleanup
SlackSheet
scroll indicator inset propScreen recordings / screenshots
RPReplay_Final1738083940.MP4
What to test