Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update react-remove-scroll to v2.5.4 #505

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

markdalgleish
Copy link
Contributor

This update fixes an issue where page content can jump around when the modal is opened if scrollbars are permanently visible. More detail: theKashey/react-remove-scroll#71

Closes #408.

@markdalgleish markdalgleish requested a review from a team as a code owner June 15, 2022 04:42
@linear
Copy link

linear bot commented Jun 15, 2022

TEAM1-20 Fix scrollbar jitter when opening modal

Note that I needed to force scrollbars to be permanently visible to reproduce this issue (System Preferences > General > Show scroll bars = "Always")

GitHub PR from outside the org that adds a workaround for the issue: #408

However, this has now been fixed in the latest version of react-remove-scroll so we should just update instead.

@vercel
Copy link

vercel bot commented Jun 15, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
rainbowkit-example ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 4:42AM (UTC)
rainbowkit-site ✅ Ready (Inspect) Visit Preview Jun 15, 2022 at 4:42AM (UTC)

Copy link
Contributor

@peduarte peduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicceeeee

@markdalgleish markdalgleish merged commit 9d431fb into main Jun 16, 2022
@markdalgleish markdalgleish deleted the @markdalgleish/TEAM1-20-fix-scrollbar-jitter branch June 16, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants