Add support for simple, non-semver version tags in the format "v1". #747

lib/package-managers/gitTags.js

@@ -24,6 +24,7 @@ const greatest = async (name, version, options) => {
 
   // eslint-disable-next-line fp/no-mutating-methods
   const tags = [...tagMap.keys()]
+    .map(tag => versionUtil.isSimpleVersion(tag) ? tag + '.0.0' : tag)
     .filter(semver.valid)
     .sort(versionUtil.compareVersions)
   const latestVersion = tags[tags.length - 1]

lib/version-util.js

@@ -286,9 +286,13 @@ const getGithubUrlTag = declaration => {
  */
 const upgradeGithubUrl = (declaration, upgraded) => {
   const tag = parseGithubUrl(declaration).branch
-  return declaration.replace(tag, upgraded)
+  const upgradedWithSimpleStripped = isSimpleVersion(tag) ? upgraded.replace('.0.0', '') : upgraded
+  return declaration.replace(tag, upgradedWithSimpleStripped)
 }
 
+/** Checks if a string is a simple version in the format "v1". */
+const isSimpleVersion = s => /^[vV]\d+$/.test(s)
+
 module.exports = {
   compareVersions,
   numParts,
@@ -298,6 +302,7 @@ module.exports = {
   setPrecision,
   addWildCard,
   isPre,
+  isSimpleVersion,
   isWildCard,
   isWildPart,
   colorizeDiff,

test/test-versionmanager.js

@@ -497,7 +497,7 @@ describe('versionmanager', () => {
         })
       })
 
-      it('skip github url tags that are not valid semver', async () => {
+      it('ignore tags that are not valid semver', async () => {
         const upgrades = await vm.queryVersions({
           // this repo has tag "1.0" which is not valid semver
           'ncu-test-invalid-tag': 'raineorshine/ncu-test-invalid-tag.git#v3.0.0'
@@ -508,6 +508,17 @@ describe('versionmanager', () => {
         })
       })
 
+      it('support the non-semver tag "v1"', async () => {
+        const upgrades = await vm.queryVersions({
+          // this repo has tag "1.0" which is not valid semver
+          'ncu-test-invalid-tag': 'git+https://github.com/raineorshine/ncu-test-simple-tag#v1'
+        }, { loglevel: 'silent' })
+
+        upgrades.should.deep.equal({
+          'ncu-test-invalid-tag': 'git+https://github.com/raineorshine/ncu-test-simple-tag#v3'
+        })
+      })
+
       it('private github urls with tags should be ignored', async () => {
         const upgrades = await vm.queryVersions({
           'ncu-test-alpha': 'git+https://username:dh9dnas0nndnjnjasd4@bitbucket.org/somename/common.git#v283',