Skip to content

Sort hashed data before testing its order #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 16, 2024
Merged

Sort hashed data before testing its order #1

merged 1 commit into from
Aug 16, 2024

Conversation

workingjubilee
Copy link
Contributor

This is the implication of RandomState and HashMap::iter.

@workingjubilee
Copy link
Contributor Author

Currently the test can sporadically fail.

@workingjubilee workingjubilee mentioned this pull request Aug 11, 2024
Closed
rainhead
rainhead approved these changes Aug 16, 2024
View reviewed changes
Copy link
Owner

@rainhead rainhead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rainhead rainhead merged commit 2eaaa96 into rainhead:main Aug 16, 2024
@workingjubilee workingjubilee deleted the sort-vec-before-cmp branch August 18, 2024 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainhead rainhead rainhead approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@workingjubilee @rainhead