Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: separate Client and Conn #1

Open
wants to merge 39 commits into
base: master
Choose a base branch
from
Open

refactor: separate Client and Conn #1

wants to merge 39 commits into from

Conversation

shaxbee
Copy link

@shaxbee shaxbee commented Dec 17, 2020

Provide Invoke and Callback API in client to robustly subscribe to bittrex feeds, example/bittrex/main.go is demo that subscribes to order book deltas and prints them out to stdout.

shaxbee added 22 commits November 30, 2020 14:56
@shaxbee
refactor: use context.Context, guarantee sync processing in ReadMessages
97ba0d9
@shaxbee
refactor: make negotiate/connect/start private
72cf6c3
@shaxbee
feat: integration test
dca2e39
@shaxbee
feat: tests for client TLS and read message
e1116e2
@shaxbee
chore: remove format workflow step as its handled automaticaly by gol…
940d80d 
…angci-lint
@shaxbee
feat: test for reconnect after websocket close
463758c
@shaxbee
feat: propagate context deadline to underlying websocket read/write
297d9e4
@shaxbee
chore: change ClientMsg args to []json.RawMessage
41fab1e
@shaxbee
feat: change type of Message.I
fc94ba8
@shaxbee
fix: populate url query on connect/reconnect
800fbd6
@shaxbee
fix: ignore empty messages
e353100
@shaxbee
refactor: separate client and connection
0184091
@shaxbee
fix: release lock in Client.process
0f197cf
@shaxbee
fix: add NewClient
9077863
@shaxbee
refactor: return error immediately in callback
a95aa5d
@shaxbee
fix: callback backlog
0761644
@shaxbee
refactor: return InvocationResult to allow delayed parsing of result
04ffaec
@shaxbee
refactor: refine callback and invoke interface
abbc3b0
@shaxbee
refactor: pass context when creating callback
798d923
@shaxbee
fix: close callback channel on sender side
8503f76
@shaxbee
refactor: manage invocations/callbacks in specialized structs
34956e6
@shaxbee
chore: improve bittrex example, add timeouts to operations
516818e
@shaxbee
Copy link
Author

shaxbee commented Dec 18, 2020

BTW this code is already used in ATP.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 1, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

tepavac added 4 commits October 3, 2021 08:39
@tepavac
CRS use blocking channel when processing messages.
1279576 
Signed-off-by: Milos Tepavac <milos@rain.bh>
@tepavac
Merge pull request #7 from rainhq/milos.blocking.channel
c2a76fc 
CRS use blocking channel when processing messages.
@tepavac
Revert back to non blocking channel when processing messages.
c139885 
Signed-off-by: Milos Tepavac <milos@rain.bh>
@tepavac
Merge pull request #8 from rainhq/milos.callback.process.channel
ab0b7b3 
Use non blocking channel when processing callback messages.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

arammkr added 3 commits May 19, 2022 18:23
[FIX]: make signalr message processing action as a blocking with conf…
5eb6c51 
…igurable timeout
[FIX]: minor updates
a021165
Merge pull request #15 from rainhq/aram.satpan-103.fix-signalr-messag…
143fa4a 
…e-processing

[SATPAN-103]: make signalr message processing action as a blocking with conf…
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@askretov
[SRPRO-1673] Explicit connection close method added for Client. Reque…
5006232 
…st headers leak fixed. We don't share the same defaultConfig instance anymore but instantiating a new copy instead every time we need default config.
@askretov
Merge pull request #21 from rainhq/aleksandr.SRPRO-1673.ws-conn-close…
da0e83c 
…-and-headers-leak-fix

[SRPRO-1673] Headers leak fix & conn close method
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedalhulaibi ahmedalhulaibi Awaiting requested review from ahmedalhulaibi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shaxbee @mkmule @tepavac @askretov