Reduce allocs by pooling gzip.Writer objects #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pretty simple change to pool for reuse. This came about because an instance of metric that was running had a pprof that looked like:
Showing that
flate.NewWriter
was by far the largest source of allocations in our process. I tracked that to this component. I have already released this change to our production cluster and have seen a significant reduction andflate.NewWriter
has completely dropped from the pprof output.Benchcmp results: