remove unused serialization functions, add one #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
with the latest changes to the MT PR 1335 some of the existing serialization functions are not going to be used anymore, while Archive needs to be serializable. So this just updates those serialization functions accordingly. Once it is merged I'll update the branch of PR 1335 to vendor the latest version of raintank/schema.
|
Has this been tested with the branch that requires the changes (grafana/metrictank#1335)? |
|
Yeah. Actually I first wrote those modifications in the MT vendor directory and tested them there. Then I just copied them over into this branch regenerated the generated files. |
robert-milan
approved these changes
Jun 12, 2019
because they are also not used
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
with the latest changes to the MT PR grafana/metrictank#1335 some of the existing
serialization functions are not going to be used anymore, while
Archiveneeds to be serializable. So this just updates those serialization
functions accordingly. Once it is merged I'll update the branch of PR
1335 to vendor the latest version of raintank/schema.