Support YML file argument #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@comonadd can you please rebase to fix the conflicts? |
comonadd
force-pushed
the
support-specific-file-theme
branch
from
cabd5b1 to
4b4663a
Compare
comonadd
force-pushed
the
support-specific-file-theme
branch
from
4b4663a to
e8541cf
Compare
|
Fixed |
JuanVqz
requested changes
Sep 15, 2021
index.js
Outdated
| fs.existsSync(theme) && !fs.lstatSync(theme).isDirectory(); | ||
| const themePath = isSpecificFile | ||
| ? theme | ||
| : path.join(__dirname, `themes/${theme}.yml`); |
There was a problem hiding this comment.
Suggested change
| : path.join(__dirname, `themes/${theme}.yml`); | |
| : themeFilePath(theme); |
JuanVqz
approved these changes
Sep 15, 2021
JuanVqz
pushed a commit
that referenced
this pull request
Sep 16, 2021
* Support YML file argument * Use themeFilePath for finding theme directory config file path
|
🎉 This PR is included in version 4.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #1