feat(provider): support gitlab-ci #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @rajatjindal |
|
this is so awesome. I am sorry to have completely missed this PR. I will find time this weekend to get this PR tested and merged. thanks again. |
mbobrovskyi
force-pushed
the
feature/support-gitlab-ci
branch
3 times, most recently
from
fadcdfa
to
a84b06e
Compare
mbobrovskyi
force-pushed
the
feature/support-gitlab-ci
branch
from
a84b06e
to
0eb84e4
Compare
mbobrovskyi
force-pushed
the
feature/support-gitlab-ci
branch
from
0eb84e4
to
823c6ea
Compare
mbobrovskyi
changed the title
mbobrovskyi
force-pushed
the
feature/support-gitlab-ci
branch
from
823c6ea
to
f017532
Compare
|
this is looking good to me. could you please remove the vendor directory. also have you tried running this on some gitlab project? if so, could you please share the execution link (or screenshot). thank you for your contribution |
mbobrovskyi
force-pushed
the
feature/support-gitlab-ci
branch
from
f017532
to
a6de845
Compare
Oh, thanks! |
Just for test created simple one https://gitlab.com/mbobrovskyi/my-kubectl-plugin. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support GItLab CI.
Fixes #59