Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

name added to config.yaml when creating a new run mode #88

Closed
nukappa opened this issue Jan 16, 2024 · 2 comments
Closed

name added to config.yaml when creating a new run mode #88

nukappa opened this issue Jan 16, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@nukappa
Copy link
Member

nukappa commented Jan 16, 2024

Leaving this here so we don't forget. For example, running spacemake config add_run_mode --name newrunmode will add the following to config.yaml:

  newrunmode:
    name: newrunmode
    spatial_barcode_min_matches: 0

Not sure if it matters downstream though, i.e. if the name is used somewhere. To be updated.

@nukappa
Copy link
Member Author

nukappa commented Jan 17, 2024

Can verify that it doesn't matter for downstream analysis. Also adding a 2nd run_mode will add a name to the newest run mode and will remove it from the one previously added.

@danilexn danilexn added the bug Something isn't working label Jan 17, 2024
@marvin-jens marvin-jens self-assigned this Jan 26, 2024
marvin-jens added a commit that referenced this issue Jan 26, 2024
…when-creating-a-new-run-mode

fix #88 name added to configyaml when creating a new run mode
@marvin-jens
Copy link
Member

it is fixed now on fast-cmdline, which is going to be merged with master soonish, so Im closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants