Fix/incidents 1 #302
Merged
Fix/incidents 1 #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves incident display and management by introducing configurable incident group views and enhancing comment rendering to support HTML content. Solves the bug raised in #295 where server crashes when an incident is created from an alert Refines SMTP email settings by adding TLS configuration and allowing username/password to be optional. #300 and #298 Also, fixes a bug where only home page was being filtered. Now all pages are filtered. #297
…tton in monitors management
… description formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes various updates and improvements across multiple files, focusing on enhancing user experience, improving incident management, and refining server-side functionalities. Below are the most important changes grouped by theme:
User Experience Enhancements:
src/lib/components/IncidentNew.svelte: Added logic to setaccordionValuebased onincidentGroupViewand updated theAccordion.Itemto useaccordionValue. Also, changed the comment display to use@htmlfor rendering HTML content. [1] [2] [3]src/lib/components/manage/homePage.svelte: IntroducedincidentGroupViewwith options to expand or collapse incidents and updated the form to include a dropdown for selecting the incident group view. [1] [2] [3] [4] [5]src/lib/components/manage/monitorsAdd.svelte: Added anExternalLinkbutton to navigate to the monitor's URL. [1] [2]Incident Management Improvements:
src/lib/server/alerting.js: Enhanced the incident description formatting with HTML for better readability.src/lib/server/controllers/controller.js: AddedincidentGroupViewto the site data keys and ensured incidents are correctly associated with alerts. [1] [2] [3]Server-Side Enhancements:
src/lib/server/constants.js: Added a new constantWEBHOOK. [1] [2]src/lib/server/db/dbimpl.js: Updated thecreateIncidentmethod to return the incident object and added a method to check if an alert exists for a given incident. [1] [2] [3] [4] [5]src/lib/server/cron-minute.js: Refined imports and constants to includeWEBHOOKand other status types. [1] [2]src/lib/server/webhook.js: Updated webhook-related functions to use theWEBHOOKconstant. [1] [2] [3] [4] [5]Documentation Updates:
docs/environment-vars.md: Added notes explaining the use ofSMTP_SECUREand how to handle SMTP credentials.docs/triggers.md: Added a note about settingSMTP_USERandSMTP_PASSto-if the SMTP provider requires credentials.Miscellaneous:
src/app.postcss: Removed the import offonts.cssand thefont-familydefinition. [1] [2]src/lib/server/notification/smtps.js: Adjusted the SMTP transport creation logic to handle cases where username and password are not required.