Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5 #12

Merged
merged 1 commit into from
Sep 15, 2024
Merged

Fix #5 #12

merged 1 commit into from
Sep 15, 2024

Conversation

theludovyc
Copy link
Collaborator

@theludovyc theludovyc commented Sep 14, 2024

fix #5

In SceneLoader to change_scene, change_scene_to_loading_screen and
change_scene_to_resource to not play the open transition
Rename _wait_after_load in _force_wait_after_load it is more
comprehensive

@theludovyc theludovyc added the enhancement New feature or request label Sep 14, 2024
@theludovyc theludovyc added this to the 1.1 milestone Sep 14, 2024
@theludovyc theludovyc marked this pull request as ready for review September 15, 2024 13:04
@theludovyc theludovyc marked this pull request as draft September 15, 2024 13:05
In SceneLoader to change_scene, change_scene_to_loading_screen and
change_scene_to_resource to not play the open transition
Rename _wait_after_load in _force_wait_after_load it is more
comprehensive
@theludovyc theludovyc marked this pull request as ready for review September 15, 2024 13:07
@Jeremi360
Copy link
Contributor

Jeremi360 commented Sep 15, 2024

everytinhg okay I would just change desretion of changes as it is hard to read.
Please use `` for classes, vars, methods, etc.

For example:

Rename _wait_after_load in _force_wait_after_load it is more
comprehensive`

It should be:

  • Rename _wait_after_load() to _force_wait_after_load() as it is more
    comprehensive

@Jeremi360 Jeremi360 merged commit 3e2ab83 into rakugoteam:main Sep 15, 2024
@Jeremi360 Jeremi360 mentioned this pull request Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ench] Only open transition after bootsplash
2 participants