Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new information to LRD #365
Add new information to LRD #365
Changes from all commits
4c049d9
61954bb
f6c64c0
e7c120d
205fce7
3be2902
1d06ede
4ef501c
5cecb13
059f297
e13b3bb
bd945b6
d0631de
0580b88
35c404f
08450aa
94c55bc
fe09ae6
5f445fa
41fd5ae
b04297b
0fd985f
d2a7ad4
e9bc970
1d153a3
70f6c10
a03aeb4
5f0fdd0
fe0867e
b9b4853
17531cc
ee6edf3
385665e
e08679a
d91436d
2934117
c0dbecc
8a8f6ed
1b0f798
498385d
0fab236
75f1221
349075c
8c2833f
c82b614
d1464e7
ff9bef7
721a085
0356b3c
eb22bf4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May I know why do we need to add this ordering?
If the user want to decided the ordering, can't they define from the
rules
?'page' => 'nullable|integer|min:1',
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The definition can only be done through the format that the operator defines in the rule as you posted, but when winning as a team the rules are not always defined in the same order so we don't have a standard and at least in my opinion it looks messy in documents like In the print below, I added this option simply to organize the rules cohesively but there is still the possibility of not passing the ordering and thus returning as defined in the method