fix: Link libportmidi correctly on Darwin #42
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rakyll 🙏 |
jmacd
approved these changes
Sep 13, 2022
|
I don't have write access to the repo so I can't merge - @jmacd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
portmidi.handporttime.hto/libas mentioned in the issue: Distribute portmidi and porttime headers as a part of the repo #3Fixes failing builds on Darwin due to hardcoded path to
libportmidi.dylib, only compatible with the Linux filesystem. The fix consists of using#cgo darwin LDFLAGSand#cgo linux LDFLAGSto reference the library.