Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DateHandler when dealing with dates on DB backend #225

Closed
2 tasks
MRichards99 opened this issue Apr 26, 2021 · 0 comments · Fixed by #232
Closed
2 tasks

Use DateHandler when dealing with dates on DB backend #225

MRichards99 opened this issue Apr 26, 2021 · 0 comments · Fixed by #232
Assignees
@MRichards99
Labels
db backend Issues relating to the DB backend refactor

Comments

@MRichards99
Copy link
Collaborator

Description:
The ICAT backend uses a datetime format which includes timezone data (2000-05-07 00:00:00+00:00). This is managed by the DateHandler class (stored in datagateway_api/common/date_handler.py).

This is part of the work for #213

Acceptance criteria:

  • Both backends should have timezones and follow the same datetime format (as above)
  • A user should be able to easily 'round trip' data involving datetimes (i.e. copy from a GET, paste into a PATCH request without needing to change the format) as this is possible on the ICAT backend
@MRichards99 MRichards99 added refactor db backend Issues relating to the DB backend labels Apr 26, 2021
@MRichards99 MRichards99 self-assigned this Apr 29, 2021
MRichards99 added a commit that referenced this issue May 5, 2021
@MRichards99
#225: Add timezone info to datetimes on DB backend
f30caa6
MRichards99 added a commit that referenced this issue May 5, 2021
@MRichards99
#225: Add timezone info to session details on ICAT backend
26b7bd6
MRichards99 added a commit that referenced this issue May 5, 2021
@MRichards99
#225: Fix tests involving timezone data
9b2dc7d
@MRichards99 MRichards99 mentioned this issue May 5, 2021
Merged
3 tasks
MRichards99 added a commit that referenced this issue May 14, 2021
@MRichards99
#225: Fix timezone-related issues found by merging master
dc583a8 
- These issues were a result of writing new code that involved timezones before master got merged in, which had the original fixes for timezones on DB backend
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MRichards99 MRichards99

Labels
db backend Issues relating to the DB backend refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Timezone Data to DB Backend ral-facilities/datagateway-api
1 participant
@MRichards99