Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will close #250
Description
After learning how to do test mocking, just thought I'd try and increase test coverage where there's easy wins to do so. Like I've done before, I've kind've left the DB backend coverage alone as the backend specific tests might be able to be combined through #213 in the future.
Testing Instructions
No functionality change, just make sure you're happy with the new tests :)
icatdb Generator Script Consistency Test
CI job fails, is this because of adeliberate change made to the script to change generated data (which isn't
actually a problem) or is there an underlying issue with the changes made?
Agile Board Tracking
Connect to #250