Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable HTTPS download button if status is not complete #1261

Closed
1 task
louise-davies opened this issue May 24, 2022 · 0 comments · Fixed by #1266
Closed
1 task

Disable HTTPS download button if status is not complete #1261

louise-davies opened this issue May 24, 2022 · 0 comments · Fixed by #1266
Assignees
@louise-davies
Labels
bug Something isn't working datagateway-download Issues relating to the download plugin

Comments

@louise-davies
Copy link
Member

Description:
A small bug - for HTTPS downloads the download button is always clickable, even though it should be disabled if the download is not in the COMPLETE state.

Acceptance criteria:

  • HTTPS download button only enabled when download status is COMPLETE
@louise-davies louise-davies added bug Something isn't working datagateway-download Issues relating to the download plugin labels May 24, 2022
@louise-davies louise-davies self-assigned this May 25, 2022
louise-davies added a commit that referenced this issue May 25, 2022
@louise-davies
#1261 - disable HTTPS downloads with non-COMPLETE statuses
2171dfb
louise-davies added a commit that referenced this issue May 27, 2022
@louise-davies
#1261 - adjust tests for new download disable behaviour
be7b5d4 
- also tidy up code in the download button
@louise-davies louise-davies mentioned this issue May 27, 2022
Merged
4 tasks
louise-davies added a commit that referenced this issue May 27, 2022
@louise-davies
Merge pull request #1266 from ral-facilities/bugfix/disable-download-…
3c7a2d2 
…button-#1261

Bugfix/disable download button #1261
louise-davies added a commit that referenced this issue Jun 15, 2022
@louise-davies
#1261 - display more helpful message on network error
408aabb
louise-davies added a commit that referenced this issue Jun 15, 2022
@louise-davies
#1261 - show checkboxes/add to cart button as disabled w/ tooltip whe…
d059840 
…n cart hasn't loaded

- also refactor some tooltips to be styled only once
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louise-davies louise-davies

Labels
bug Something isn't working datagateway-download Issues relating to the download plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bugfix/disable download button #1261 ral-facilities/datagateway
1 participant
@louise-davies