Preventing download of empty files #1195 #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 22, 2022 14:02
…#1195 This involves passing the size of the relevant entity to the download button. In table and card view, this involves making use of the sizeQueries array. If the button is disabled, the user can move their mouse over the button to show a tooltip explaining the file is empty and thus cannot be downloaded.
sam-glendenning
added
bug
Codecov Report
@@ Coverage Diff @@
## develop #1232 +/- ##
===========================================
- Coverage 97.51% 97.47% -0.04%
===========================================
Files 133 133
Lines 6753 6785 +32
Branches 2000 2059 +59
===========================================
+ Hits 6585 6614 +29
- Misses 153 155 +2
- Partials 15 16 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
added 2 commits
April 22, 2022 16:26
Pointless having it anyway and removing it boosts test coverage
|
Other than those minor points about the tooltip it seems to be working well |
louise-davies
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This requires passing the size of the relevant entity to the download button. In table and card view, we make use of the
sizeQueriesarray for this, disabling the download button until we can confirm the entity size is greater than zero (realistically, this happens quickly enough that the user does not notice). If the button is disabled, the user can move their mouse over the button to show a tooltip explaining the file is empty and thus cannot be downloaded.Testing instructions
This should be tested with SciGateway and both Dataview and Search. The download button appears as both a box and an icon in many places so it's important to test it enables and disables properly everywhere. If you're hooked up to the production IDS, you'll get a variety of empty and non-empty sets of data to properly test this. Make sure that every time the button is disabled, a tooltip displays over it. Also check to see how this all looks in light/dark mode and give any thoughts on that too if you have any.
Agile board tracking
Closes #1195