Prevent querying for cart on homepage & fix admin download table queries #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if viewing homepage when not logged in then the request will throw an error
- Removed unnecessary UPPERs which were breaking sorts (also just removed any that weren't broken but unecessary) - Set not set start date to 0001 rather than 0000 to avoid Oracle error
… files - this makes it easier to have facility specific config files ignored
Codecov Report
@@ Coverage Diff @@
## develop #1250 +/- ##
========================================
Coverage 97.47% 97.48%
========================================
Files 133 133
Lines 6785 6787 +2
Branches 2059 2059
========================================
+ Hits 6614 6616 +2
Misses 155 155
Partials 16 16
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
sam-glendenning
approved these changes
May 12, 2022
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new SciGateway change to allow unauthenticated access to the homepage, it meant the user was seeing errors as the cart was requested on the homepage. I justed jiggled the code around to create an extra component so that the cart is only requested on "actual" dataview pages.
The second change is to fix some of the querying in the admin download table - there were
UPPERs being applied too liberally and breaking things (e.g. the sorting) so I only kept theUPPERs where necessary - for text filters. Also, I noticed that only setting the to field in a date filter threw an error when done against an Oracle DB due to Oracle not accepting the year being 0 (this issue is also present on TopCAT). So I set it to 1 instead which avoids the error.Testing instructions
Add a set up instructions describing how the reviewer should test the code
Agile board tracking
No issue as these are things I found whilst doing the DLS demo so I made hotfixes for them.