#1397 - make fileCountMax / totalSizeMax optional

[louise-davies]

This means we can more easily remember to check if they're set to a valid number via TS and to disable any features related to them if they're undefined - primilary what's fixed here is the "too many/much" alerts.

Because this is needed to create a patch release, it's needs to merge onto main (and it branched from main). I will then merge main into develop + resolve any merge conflicts.

Description

Enter a description of the changes here

Testing instructions

Add a set up instructions describing how the reviewer should test the code

• Review code
• Check Actions build
• Review changes to test coverage
• {more steps here}

Agile board tracking

Closes #1397

[louise-davies]

Note - because this is branched from main, it is before the yarn 2 upgrade and so it will likely bork your existing repo's dependencies. I'd suggest checking this out in a seperate clone of the repo/git worktree so as to not cause as muh trouble when switching back to develop later.

[codecov]

Codecov Report

Merging #1398 (d8f070f) into main (7324fc0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1398   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         134      134           
  Lines        6827     6827           
  Branches     2094     2094           
=======================================
  Hits         6656     6656           
  Misses        155      155           
  Partials       16       16           

Flag	Coverage Δ
common	98.16% <ø> (ø)
dataview	97.98% <ø> (ø)
download	94.96% <100.00%> (ø)
search	97.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ckages/datagateway-download/src/ConfigProvider.tsx	100.00% <ø> (ø)
...d/src/downloadCart/downloadCartTable.component.tsx	93.28% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[sam-glendenning]

May also want to amend the code at

datagateway/packages/datagateway-common/src/table/cellRenderers/cellContentRenderers.tsx

Line 7 in 923473a

export function formatBytes(bytes: number | undefined): string {

since parts of it are no longer relevant

Edit: never mind, it's still used in the calculation of totalSize