Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rollup to v4.22.5 #1094

Merged
merged 1 commit into from
Oct 30, 2024
Merged

Update rollup to v4.22.5 #1094

merged 1 commit into from
Oct 30, 2024

Conversation

joelvdavies
Copy link
Collaborator

@joelvdavies joelvdavies commented Oct 28, 2024

Description

I intended to only add the resolution to force the update. But it ended up requiring it as if I remove it, the next yarn install immediately replaces rollup with the latest version which hasn't even made 24 hours after release yet. So had to leave it in.

(We should probably remove it on develop once merged)

Updated using yarn set resolution rollup@npm:^4.20.0 npm:4.22.5.

Testing instructions

Add a set up instructions describing how the reviewer should test the code

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.42%. Comparing base (ee1486e) to head (2451ff0).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff            @@
##             main    #1094    +/-   ##
========================================
  Coverage   83.42%   83.42%            
========================================
  Files         163      163            
  Lines       39004    39004            
  Branches     4162     4996   +834     
========================================
  Hits        32540    32540            
+ Misses       6433     6429     -4     
- Partials       31       35     +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joelvdavies joelvdavies merged commit 0cc324e into main Oct 30, 2024
6 checks passed
@joelvdavies joelvdavies deleted the update-rollup-to-v4.22.5 branch October 30, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants