Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate spares definition with catalogue items and items #1162 #1166

Draft
wants to merge 7 commits into
base: add-and-view-a-spares-definition-#1161
Choose a base branch
from

Conversation

joshuadkitenge
Copy link
Collaborator

Description

add spares link button to catalogue items table , landing page and details panel

Testing instructions

  • Review code
  • Check Actions build
  • Review changes to test coverage

Agile board tracking

#1162

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 98.06452% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.98%. Comparing base (16f9001) to head (899caa5).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...gue/items/catalogueItemsDetailsPanel.component.tsx 95.65% 1 Missing ⚠️
...ogue/items/catalogueItemsLandingPage.component.tsx 92.85% 1 Missing ⚠️
src/utils.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                            Coverage Diff                             @@
##           add-and-view-a-spares-definition-#1161    #1166      +/-   ##
==========================================================================
- Coverage                                   98.98%   98.98%   -0.01%     
==========================================================================
  Files                                         101      102       +1     
  Lines                                       17911    18047     +136     
  Branches                                     3055     3079      +24     
==========================================================================
+ Hits                                        17730    17863     +133     
- Misses                                        177      180       +3     
  Partials                                        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshuadkitenge joshuadkitenge force-pushed the integrate-spares-definition-with-catalogue-items-and-items-#1162 branch from 30ca5b2 to d9388fb Compare December 18, 2024 11:47
@joshuadkitenge joshuadkitenge force-pushed the add-and-view-a-spares-definition-#1161 branch from 97400e7 to a9264de Compare December 19, 2024 12:09
Comment on lines +362 to +363
) : typeof cellData === 'number' ? (
cellData
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was needed as 0 is falsy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant